fix(playground): use visibility hidden to hide iframe for proper loading#2623
Merged
brandyscarney merged 1 commit intomainfrom Oct 26, 2022
Merged
fix(playground): use visibility hidden to hide iframe for proper loading#2623brandyscarney merged 1 commit intomainfrom
brandyscarney merged 1 commit intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
sean-perkins
approved these changes
Oct 26, 2022
averyjohnston
approved these changes
Oct 26, 2022
Contributor
averyjohnston
left a comment
There was a problem hiding this comment.
I was also able to replicate the issue by reloading the iframes when on md mode, then switching back to ios, which is now borked (which makes it more obvious that there's actually a problem and it's not just md behavior): https://user-images.githubusercontent.com/90629384/198069660-684407ac-4c72-43ac-b8b5-50f532079a54.mp4 This doesn't happen on the branch preview, of course.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While working on #2622 I noticed that the
fullscreenproperty would only apply to the first iframe that gets loaded, so usuallyiosonly and notmd. This can be reproduced on the live documentation too.Steps to reproduce:
iosmode, you'll see the footer is translucent and content is behind it.mdmode, scroll to the very bottom and you'll see the scrollbar ends above the footer. This should be behind the footer.An easier way to see it is by running the documentation locally on
mainand adding the following CSS to the test atstatic/usage/footer/translucent/demo.html:Then when you view the test at http://localhost:3000/docs/api/footer#translucent-footer, you will be able to switch between the modes and see that the red from the content is not behind the toolbar. If you change the mode then click the
Reset Demoicon on the playground, you will see the toolbar is properly transparent.This bug is caused by the
iframebeing set todisplay: nonewhen the content does thefullscreencalculations. In order to fix it I have changed the iframe tovisibility: hiddenand also set the width to0so it doesn't take up any space.I don't know what this CSS was there for but it adds a horizontal scroll in
iosmode if I leave it in: