Closed
Conversation
|
@derf974 is attempting to deploy a commit to the Ionic Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
|
Thank you for the PR! Looking into this further, it looks like the better approach is to mark I've created a separate PR that makes this change instead: #2926 You'll be given co-author credit when the PR is merged. Closing this one out in favor of the newer one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sorry I'm beginner with ionic ,
Tell me if i'm wrong but when i tried to do the "Getting Started", it's raised me an error :
Type 'string | undefined' is not assignable to type 'string'.
[ng] Type 'undefined' is not assignable to type 'string'.
I found this fix.