fix(playground): demo container is visible on small viewports#2754
Merged
sean-perkins merged 1 commit intomainfrom Feb 2, 2023
Merged
fix(playground): demo container is visible on small viewports#2754sean-perkins merged 1 commit intomainfrom
sean-perkins merged 1 commit intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
liamdebeasi
approved these changes
Feb 2, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the sizing of the rendered
iframeto fill the available space.When previewing on a Pixel 5 (can be observed with Chrome Dev Tools/Device Emulation): https://ionicframework.com/docs/v7/api/toast the rendered previews are not visible.
Reported on Twitter: https://twitter.com/vberchet/status/1620981423644475396
Quick preview: https://ionic-docs-git-fix-playground-sizing-ionic1.vercel.app/docs/api/toast