feat(vue): web-types support#22428
Merged
liamdebeasi merged 2 commits intoionic-team:masterfrom Nov 5, 2020
Merged
Conversation
Contributor
|
Thank you! This looks great. I created a dev build and tested it in the latest version of WebStorm, and it is working well: |
liamdebeasi
suggested changes
Nov 4, 2020
Contributor
liamdebeasi
left a comment
liamdebeasi
left a comment
There was a problem hiding this comment.
One small change, otherwise looks great.
liamdebeasi
changed the title
Co-authored-by: Liam DeBeasi <liamdebeasi@users.noreply.github.com>
liamdebeasi
approved these changes
Nov 5, 2020
Contributor
liamdebeasi
left a comment
liamdebeasi
left a comment
There was a problem hiding this comment.
Thank you for this! I will make sure this gets into our next minor release.
Contributor
|
Merged. Thank you! This will be in our next minor release. |
Contributor
Author
|
Thank you! |
TakumaKira
pushed a commit
to TakumaKira/ionic-framework
that referenced
this pull request
Nov 13, 2020
|
Thank you @piotrtomiak! WebStorm rules! |
|
I know this commit is old but seems like it is still an issues with Ionic v6.1.5. I can't get Webstorm autocomplete work. Web-types.json is empty The web-type.json in the "@Ionic" node_modules looks like this :
Can anyone help me? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
npm run build) was run locally and any changes were pushednpm run lint) has passed locally and any fixes were made for failuresPull request type
Please check the type of change your PR introduces:
What is the current behavior?
Issue Number: resolves #19522
What is the new behavior?
This PR introduces bundling of web-types with
@ionic/vuefor in-editor documentation support. The web-types standard is an open source standard supported so far only by WebStorm and is bundled with various other Vue libraries, likevuetify,bootstrap-vueorquasar.Does this introduce a breaking change?
Other information