Skip to content

refactor(header): removed border from last toolbar when using collapsible large title#22849

Merged
liamdebeasi merged 3 commits intonextfrom
large-title-border
Feb 8, 2021
Merged

refactor(header): removed border from last toolbar when using collapsible large title#22849
liamdebeasi merged 3 commits intonextfrom
large-title-border

Conversation

@liamdebeasi
Copy link
Contributor

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: resolves #22777

What is the new behavior?

  • Uncollapsed large title no longer has border

Does this introduce a breaking change?

  • Yes
  • No

Other information

@github-actions github-actions bot added the package: core @ionic/core package label Feb 1, 2021
@liamdebeasi liamdebeasi changed the title breaking(header): removed border from last toolbar when using collapsible large title refactor(header): removed border from last toolbar when using collapsible large title Feb 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

package: core @ionic/core package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants