Skip to content

refactor(toast): whitespace variable now defaults to normal#22866

Merged
liamdebeasi merged 1 commit intonextfrom
toast-ws
Feb 5, 2021
Merged

refactor(toast): whitespace variable now defaults to normal#22866
liamdebeasi merged 1 commit intonextfrom
toast-ws

Conversation

@liamdebeasi
Copy link
Contributor

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: resolves #21486

What is the new behavior?

  • --white-space: normal is the new default on ion-toast.

Does this introduce a breaking change?

  • Yes
  • No

Other information

@github-actions github-actions bot added the package: core @ionic/core package label Feb 3, 2021
@liamdebeasi liamdebeasi changed the title breaking(toast): whitespace variable now defaults to normal refactor(toast): whitespace variable now defaults to normal Feb 5, 2021
@liamdebeasi liamdebeasi merged commit 9b78689 into next Feb 5, 2021
@liamdebeasi liamdebeasi deleted the toast-ws branch February 5, 2021 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

package: core @ionic/core package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants