feat(select): allow multiple selections in popover interface, ui updates#23474
Merged
liamdebeasi merged 30 commits intonextfrom Jul 20, 2021
Merged
feat(select): allow multiple selections in popover interface, ui updates#23474liamdebeasi merged 30 commits intonextfrom
liamdebeasi merged 30 commits intonextfrom
Conversation
- brings us closer to matching the Material Design spec
brandyscarney
requested review from
liamdebeasi and
willmartian
and removed request for
liamdebeasi
willmartian
approved these changes
Jul 13, 2021
Contributor
willmartian
left a comment
willmartian
left a comment
There was a problem hiding this comment.
Nice work! Added a few non-blocking suggestions.
| <ion-list> | ||
| {this.header !== undefined && <ion-list-header>{this.header}</ion-list-header>} | ||
| { (this.subHeader !== undefined || this.message !== undefined) && | ||
| {header !== undefined && <ion-list-header>{header}</ion-list-header>} |
Contributor
There was a problem hiding this comment.
Suggested change
| {header !== undefined && <ion-list-header>{header}</ion-list-header>} | |
| {header ?? <ion-list-header>{header}</ion-list-header>} |
Comment on lines
+166
to
+167
| {subHeader !== undefined && <h3>{subHeader}</h3>} | ||
| {message !== undefined && <p>{message}</p>} |
Contributor
There was a problem hiding this comment.
Suggested change
| {subHeader !== undefined && <h3>{subHeader}</h3>} | |
| {message !== undefined && <p>{message}</p>} | |
| {subHeader ?? <h3>{subHeader}</h3>} | |
| {message ?? <p>{message}</p>} |
| {this.header !== undefined && <ion-list-header>{this.header}</ion-list-header>} | ||
| { (this.subHeader !== undefined || this.message !== undefined) && | ||
| {header !== undefined && <ion-list-header>{header}</ion-list-header>} | ||
| { (subHeader !== undefined || message !== undefined) && |
Contributor
There was a problem hiding this comment.
Moving this to something like const hasSubHeaderOrMessage = subHeader !== undefined || message !== undefined; at the top of the render function makes the JSX cleaner to read, but that might just be my personal preference. :)
6 tasks
liamdebeasi
approved these changes
Jul 20, 2021
This was referenced Jul 20, 2021
13 tasks
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Features / Improvements
multiplewith the"popover"interfaceresolves #23657
resolves #15500
resolves #12310
masterbranch