Skip to content

fix(angular): modal and popover now have correct props defined on angular component#23565

Merged
liamdebeasi merged 3 commits intonextfrom
ng-overlay
Jul 1, 2021
Merged

fix(angular): modal and popover now have correct props defined on angular component#23565
liamdebeasi merged 3 commits intonextfrom
ng-overlay

Conversation

@liamdebeasi
Copy link
Contributor

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

#23561 (comment)

What is the new behavior?

Does this introduce a breaking change?

  • Yes
  • No

Other information

@github-actions github-actions bot added the package: angular @ionic/angular package label Jul 1, 2021
@liamdebeasi liamdebeasi merged commit e5a7b34 into next Jul 1, 2021
@liamdebeasi liamdebeasi deleted the ng-overlay branch July 1, 2021 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

package: angular @ionic/angular package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant