fix(datetime): default sizing preserves shape of datetime#24104
Merged
liamdebeasi merged 4 commits intonextfrom Oct 21, 2021
Merged
fix(datetime): default sizing preserves shape of datetime#24104liamdebeasi merged 4 commits intonextfrom
liamdebeasi merged 4 commits intonextfrom
Conversation
averyjohnston
suggested changes
Oct 21, 2021
Contributor
averyjohnston
left a comment
There was a problem hiding this comment.
Found a typo, but otherwise this is good to go 👍
Co-authored-by: Amanda Smith <90629384+amandaesmith3@users.noreply.github.com>
averyjohnston
approved these changes
Oct 21, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also see ionic-team/ionic-docs#2087
Pull request checklist
Please check if your PR fulfills the following requirements:
npm run build) was run locally and any changes were pushednpm run lint) has passed locally and any fixes were made for failuresPull request type
Please check the type of change your PR introduces:
What is the current behavior?
The default sizing of datetime did not look great when placed directly into a page. I also ran into some issues with that when using the datetime in the docs demos I am working on. These updates make the sizing a bit nicer.
nextbranchWhat is the new behavior?
Does this introduce a breaking change?
Other information