fix(action-sheet): add aria-labelledby#25837
Merged
averyjohnston merged 4 commits intomainfrom Aug 29, 2022
Merged
Conversation
liamdebeasi
reviewed
Aug 26, 2022
liamdebeasi
approved these changes
Aug 26, 2022
sean-perkins
approved these changes
Aug 29, 2022
This was referenced Sep 1, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
ionic-docsrepo, in a separate PR. See the contributing guide for details.npm run build) was run locally and any changes were pushednpm run lint) has passed locally and any fixes were made for failuresPull request type
Please check the type of change your PR introduces:
What is the current behavior?
ion-action-sheetdoes not have anaria-labeloraria-labelledbyattribute, which his required for thedialogrole.Issue URL: N/A (internal ticket)
What is the new behavior?
headerproperty is defined,aria-labelledbyis set to point to that element.subHeaderis not included, because ifheaderisn't defined, thesubHeaderdoesn't render either way due to it being wrapped in the header element.role="dialog"removed, since it was causing an Axe violation due to nested dialogs.Does this introduce a breaking change?
Other information
A separate PR will be made to document accessibility best practices with this change in mind.