test(menu): migrate to playwright#26187
Merged
liamdebeasi merged 16 commits intomainfrom Nov 14, 2022
Merged
Conversation
Contributor
|
Don't forget to run the screenshot update job 👀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
ionic-docsrepo, in a separate PR. See the contributing guide for details.npm run build) was run locally and any changes were pushednpm run lint) has passed locally and any fixes were made for failuresPull request type
Please check the type of change your PR introduces:
Some quirks I ran into during the test migration:
Firefox does not properly tab to the button here unless you press tab twice, so I am skipping Firefox for the focus tests
Safari does not behave the same as Chrome and Firefox in the following two cases:
bodyinstead of the button that was used to open it as seen hereThe focus trap behavior only works if the button is inside of an item as seen here:
works:
does not work:
I don't know if this is the expected behavior but since this is how the test has previously worked I didn't change it.