Skip to content

feat(input): add counter and counterFormatter#26200

Merged
liamdebeasi merged 52 commits intoFW-2591from
2591-counter
Nov 7, 2022
Merged

feat(input): add counter and counterFormatter#26200
liamdebeasi merged 52 commits intoFW-2591from
2591-counter

Conversation

@liamdebeasi
Copy link
Contributor

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
    • Some docs updates need to be made in the ionic-docs repo, in a separate PR. See the contributing guide for details.
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue URL: N/A

It is not possible to specify a counter or counterFormatter on ion-input.

What is the new behavior?

  • Added support for showing maxlength counter text via counter.
  • Added support for showing a custom formatter text via counterFormatter.
  • Deprecated the counter and counterFormatter properties on ion-item.
  • Added tests

Note: I am still missing some padding/margin styles so the screenshots will likely change again before the larger migration is complete (correctly making the style updates requires more of the input functionality to be migrated.) These changes will be made in a future PR.

Does this introduce a breaking change?

  • Yes
  • No

Other information

@github-actions github-actions bot added the package: core @ionic/core package label Nov 1, 2022
@liamdebeasi liamdebeasi marked this pull request as ready for review November 1, 2022 16:45
@liamdebeasi liamdebeasi requested a review from a team as a code owner November 1, 2022 16:45
Base automatically changed from 2591-helper to FW-2591 November 7, 2022 18:52
@liamdebeasi liamdebeasi merged commit 73c6933 into FW-2591 Nov 7, 2022
@liamdebeasi liamdebeasi deleted the 2591-counter branch November 7, 2022 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

package: core @ionic/core package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants