Skip to content

fix(input): address activation quirks#26226

Merged
liamdebeasi merged 72 commits intoFW-2591from
2591-bug-fixes
Nov 8, 2022
Merged

fix(input): address activation quirks#26226
liamdebeasi merged 72 commits intoFW-2591from
2591-bug-fixes

Conversation

@liamdebeasi
Copy link
Contributor

@liamdebeasi liamdebeasi commented Nov 3, 2022

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
    • Some docs updates need to be made in the ionic-docs repo, in a separate PR. See the contributing guide for details.
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

There are two issues:

  • An issue where clicking the space between the input and the label caused the input to not focus since we were using margin.
  • An issue where the label element was rendered even if there was nothing passed to the label prop.

What is the new behavior?

  • Spacing between label and input now uses padding
  • The <label> element is only defined if something was passed to the label prop.

Does this introduce a breaking change?

  • Yes
  • No

Other information

liamdebeasi and others added 30 commits October 31, 2022 15:38
@github-actions github-actions bot added the package: core @ionic/core package label Nov 3, 2022
@liamdebeasi liamdebeasi marked this pull request as ready for review November 3, 2022 20:58
@liamdebeasi liamdebeasi requested a review from a team as a code owner November 3, 2022 20:58
liamdebeasi and others added 2 commits November 4, 2022 16:12
Co-authored-by: Amanda Johnston <90629384+amandaejohnston@users.noreply.github.com>
Base automatically changed from 2591-placement to FW-2591 November 8, 2022 16:00
@liamdebeasi liamdebeasi merged commit 74f31ee into FW-2591 Nov 8, 2022
@liamdebeasi liamdebeasi deleted the 2591-bug-fixes branch November 8, 2022 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

package: core @ionic/core package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants