fix(input): floating label works correctly with long text and notch#26273
Merged
liamdebeasi merged 202 commits intoFW-2591from Nov 14, 2022
Merged
fix(input): floating label works correctly with long text and notch#26273liamdebeasi merged 202 commits intoFW-2591from
liamdebeasi merged 202 commits intoFW-2591from
Conversation
Contributor
Author
97f9cb1 to
4d6310d
Compare
Contributor
Author
|
No, that was some extra code I copied from the floating label. I fixed that in 336d809 and am updating screenshots. |
Contributor
averyjohnston
approved these changes
Nov 14, 2022
Contributor
averyjohnston
left a comment
There was a problem hiding this comment.
Looking good now 👍 Thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Pull request checklist
Please check if your PR fulfills the following requirements:
ionic-docsrepo, in a separate PR. See the contributing guide for details.npm run build) was run locally and any changes were pushednpm run lint) has passed locally and any fixes were made for failuresPull request type
Please check the type of change your PR introduces:
What is the current behavior?
During testing, I noticed that my implemented of the notch in the MD outline was incorrect, causing the gap to be much wider than necessary when using longer labels.
I also noticed that long label texts do not flow correctly in the container.
What is the new behavior?
Does this introduce a breaking change?
Other information