fix(breadcrumbs): color attribute shows on DOM for Vue#27068
Merged
sean-perkins merged 3 commits intomainfrom Mar 30, 2023
Merged
fix(breadcrumbs): color attribute shows on DOM for Vue#27068sean-perkins merged 3 commits intomainfrom
sean-perkins merged 3 commits intomainfrom
Conversation
|
|
github-actions
bot
added
package: core
sean-perkins
force-pushed
the
fix/breadcrumbs-color
branch
from
4074fe2 to
fd3f879
Compare
Contributor
Author
|
Do not update this branch with main 🙂 |
Co-authored-by: Maria Hutt <thetaPC@users.noreply.github.com>
sean-perkins
force-pushed
the
fix/breadcrumbs-color
branch
from
fd3f879 to
fc56c2c
Compare
liamdebeasi
reviewed
Mar 30, 2023
Comment on lines
+1
to
+7
| describe("Components: Breadcrumbs", () => { | ||
| beforeEach(() => { | ||
| cy.visit("http://localhost:8080/components/breadcrumbs"); | ||
| }); | ||
|
|
||
| it("should have color attribute", () => { | ||
| cy.get('ion-breadcrumbs#color').should('have.prop', 'color'); |
Contributor
There was a problem hiding this comment.
Don't need to address this now since this is re-landing another approved PR, but it looks like other frameworks would benefit from this check. Should this be a check in core instead of just in the Vue test app?
Contributor
There was a problem hiding this comment.
I can move it over to core after.
Contributor
Author
There was a problem hiding this comment.
Created FW-3889 to track and assigned to you @thetaPC 🚀
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
ionic-docsrepo, in a separate PR. See the contributing guide for details.npm run build) was run locally and any changes were pushednpm run lint) has passed locally and any fixes were made for failuresPull request type
Please check the type of change your PR introduces:
What is the current behavior?
Issue URL:
What is the new behavior?
Does this introduce a breaking change?
Other information