feat(range): add label prop#27408
Conversation
|
|
github-actions
bot
added
package: angular
averyjohnston
requested review from
a team,
liamdebeasi and
sean-perkins
as code owners
| }); | ||
| }); | ||
|
|
||
| test.describe('range: label prop', () => { |
There was a problem hiding this comment.
Should this be limited to only one mode and one direction? The label prop doesn't change functionality regardless of mode/direction.
There was a problem hiding this comment.
I intentionally left all the configs in because the prop needed some styling separate from the slot, so I figured it would be good to verify no visual regressions in all cases, but I could go either way on it, honestly.
There was a problem hiding this comment.
If the majority is okay as is, then I can be on board.
sean-perkins
left a comment
sean-perkins
left a comment
There was a problem hiding this comment.
Can we add an additional test for when using both a label property and label slot? This can likely be a unit test, just to query for the expected DOM node.
sean-perkins
left a comment
sean-perkins
left a comment
There was a problem hiding this comment.
Can we add an additional test for when using both a label property and label slot? This can likely be a unit test, just to query for the expected DOM node.
liamdebeasi
left a comment
liamdebeasi
left a comment
There was a problem hiding this comment.
Can we add a usage of the label prop to the a11y file so we can run axe checks?
liamdebeasi
left a comment
liamdebeasi
left a comment
There was a problem hiding this comment.
Can we add a usage of the label prop to the a11y file so we can run axe checks?
liamdebeasi
left a comment
liamdebeasi
left a comment
There was a problem hiding this comment.
Is there a docs PR associated with this?
|
Docs PR created: ionic-team/ionic-docs#2955 |
6 participants
Issue number: N/A
What is the current behavior?
Labels on
ion-rangecan only be set via thelabelslot. When only plain text is needed, this is cumbersome because you need to add an entire new element to wrap the label.What is the new behavior?
Label prop added. If both the prop and slot are used, the prop will take priority.
Does this introduce a breaking change?
Other information
7.0.6-dev.11683657201.139d03f4