fix(select): floating label covers placeholder when when blurred#27446
Merged
liamdebeasi merged 3 commits intomainfrom May 12, 2023
Merged
fix(select): floating label covers placeholder when when blurred#27446liamdebeasi merged 3 commits intomainfrom
liamdebeasi merged 3 commits intomainfrom
Conversation
|
|
liamdebeasi
commented
May 11, 2023
| const textarea = page.locator('ion-textarea'); | ||
| expect(await textarea.screenshot()).toMatchSnapshot(screenshot(`textarea-placement-floating-no-value`)); | ||
| }); | ||
| test('label should appear on top of the textarea when there is a placeholder and no value', async ({ page }) => { |
Contributor
Author
There was a problem hiding this comment.
During development I discovered we did not have test coverage for this same behavior on ion-textarea, so I added it. ion-input has test coverage already.
averyjohnston
approved these changes
May 12, 2023
liamdebeasi
added a commit
that referenced
this pull request
May 15, 2023
) Issue number: resolves #27201 --------- <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> ## What is the current behavior? <!-- Please describe the current behavior that you are modifying. --> Selects with a floating label, no value, and a placeholder should have the label cover the placeholder when blurred. One focus, the label should translate to the top of the select, and the placeholder should be visible. ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> - Floating label now covers the select and hides the placeholder when the select is blurred, matching the `ion-input` and `ion-textarea` behaviors. ## Does this introduce a breaking change? - [ ] Yes - [x] No <!-- If this introduces a breaking change, please describe the impact and migration path for existing applications below. --> ## Other information <!-- Any other information that is important to this PR such as screenshots of how the component looks before and after the change. --> --------- Co-authored-by: ionitron <hi@ionicframework.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: resolves #27201
What is the current behavior?
Selects with a floating label, no value, and a placeholder should have the label cover the placeholder when blurred. One focus, the label should translate to the top of the select, and the placeholder should be visible.
What is the new behavior?
ion-inputandion-textareabehaviors.Does this introduce a breaking change?
Other information