Skip to content

feat(toast): add part for button cancel#27922

Closed
luisbytes wants to merge 1 commit intoionic-team:6.7.xfrom
luisbytes:feat-button-cancel-part-v6
Closed

feat(toast): add part for button cancel#27922
luisbytes wants to merge 1 commit intoionic-team:6.7.xfrom
luisbytes:feat-button-cancel-part-v6

Conversation

@luisbytes
Copy link
Contributor

Issue number: #27920


What is the current behavior?

It is not possible to style the buttons with the cancel role in a toast since it uses shadow DOM and there are no exposed parts or CSS variables for the cancel buttons.

What is the new behavior?

  • Exposes the following part of a toast: button with rol cancel
  • Update the e2e toast test to check if the button-cancel part is exposed

Does this introduce a breaking change?

  • Yes
  • No

Change the css shadow part for all buttons added to a toast with the cancel role from 'button' to 'button-cancel'.

Other information

@luisbytes luisbytes requested a review from a team as a code owner August 3, 2023 03:53
@luisbytes luisbytes requested review from liamdebeasi and removed request for a team August 3, 2023 03:53
@bolt-new-by-stackblitz
Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@github-actions github-actions bot added the package: core @ionic/core package label Aug 3, 2023
@liamdebeasi
Copy link
Contributor

Thanks for the PR! As I noted in #27921 (comment), we think this is a good feature to add to Ionic. However, Ionic 6 development ended when Ionic 7 shipped earlier this year. As a result, we do not have plans to backport this feature to Ionic 6.

I am going to close this, but let me know if you have any questions.

@liamdebeasi liamdebeasi closed this Aug 3, 2023
@luisbytes luisbytes deleted the feat-button-cancel-part-v6 branch April 12, 2025 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

package: core @ionic/core package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants