feat(toast): add part for button cancel#27922
Closed
luisbytes wants to merge 1 commit intoionic-team:6.7.xfrom
luisbytes:feat-button-cancel-part-v6
Closed
feat(toast): add part for button cancel#27922luisbytes wants to merge 1 commit intoionic-team:6.7.xfrom luisbytes:feat-button-cancel-part-v6
luisbytes wants to merge 1 commit intoionic-team:6.7.xfrom
luisbytes:feat-button-cancel-part-v6
Conversation
|
|
Contributor
|
Thanks for the PR! As I noted in #27921 (comment), we think this is a good feature to add to Ionic. However, Ionic 6 development ended when Ionic 7 shipped earlier this year. As a result, we do not have plans to backport this feature to Ionic 6. I am going to close this, but let me know if you have any questions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: #27920
What is the current behavior?
It is not possible to style the buttons with the cancel role in a toast since it uses shadow DOM and there are no exposed parts or CSS variables for the cancel buttons.
What is the new behavior?
Does this introduce a breaking change?
Change the css shadow part for all buttons added to a toast with the cancel role from 'button' to 'button-cancel'.
Other information