fix(range): add correct margin in item#28161
Merged
liamdebeasi merged 21 commits intofeature-7.4from Sep 13, 2023
Merged
Conversation
17f2807 to
04ef6d4
Compare
e3feff6 to
c819116
Compare
thetaPC
reviewed
Sep 13, 2023
| $range-item-label-margin-top: 10px !default; | ||
|
|
||
| /// @prop - Bottom margin of range's label when in an item | ||
| $range-item-label-margin-bottom: 10px !default; |
Contributor
Contributor
Author
There was a problem hiding this comment.
Good point. I'll try removing the bottom margin and see how that looks.
Contributor
Contributor
Author
There was a problem hiding this comment.
When using a non-stacked label the label-text-wrapper element adds 10px of bottom margin which is why there's a difference. The same difference exists with the other form controls too, so I don't think that's something that should be handled in this PR.
mapsandapps
approved these changes
Sep 13, 2023
Contributor
mapsandapps
left a comment
There was a problem hiding this comment.
Looks good to me after the bottom margin adjustment 👍🏻
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Issue number: N/A
What is the current behavior?
As part of e6c7bb6, we added margin to the stacked label when in an item so the label doesn't run up against the divider line for an item above it. However, we did not add this same margin for range.
You can see this in the screenshot comparisons:
Notice how the checkbox in an item screenshot has top/bottom margin, but the range in an item does not.
What is the new behavior?
Does this introduce a breaking change?
Other information