fix(title): large title uses custom font on transition#28231
Merged
liamdebeasi merged 1 commit intomainfrom Sep 26, 2023
Merged
fix(title): large title uses custom font on transition#28231liamdebeasi merged 1 commit intomainfrom
liamdebeasi merged 1 commit intomainfrom
Conversation
liamdebeasi
force-pushed
the
title-clone-custom-font
branch
from
a8bd740 to
1fca7fc
Compare
liamdebeasi
requested review from
a team and
thetaPC
and removed request for
a team
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: N/A
What is the current behavior?
When testing Dynamic Font Scaling with a custom font I noticed that the large title does not respect
--ion-font-familyon transition.What is the new behavior?
--ion-font-familyNote: This happens in
maintoo which is why I am merging into there instead of the Dynamic Font Scaling branch.mainDoes this introduce a breaking change?
Other information