refactor(utils): update slotMutationController to allow multiple slot names#28396
Merged
averyjohnston merged 2 commits intoFW-2853from Nov 27, 2023
Merged
refactor(utils): update slotMutationController to allow multiple slot names#28396averyjohnston merged 2 commits intoFW-2853from
averyjohnston merged 2 commits intoFW-2853from
Conversation
liamdebeasi
approved these changes
Oct 25, 2023
Contributor
Author
|
Ah, right, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: Internal
What is the current behavior?
The internal
slotMutationControllerutility can only watch one slot name at a time.What is the new behavior?
Added the option to specify multiple slot names, any of which will trigger the callback. This change is made in preparation for upcoming
startandendslots for several form control components; it boosts performance by preventing us from needing to add multiplecreateSlotMutationControllercalls to each component.Does this introduce a breaking change?
Other information