feat(textarea): add start and end slots#28441
Merged
averyjohnston merged 22 commits intoFW-2853from Nov 27, 2023
Merged
Conversation
added 8 commits
October 20, 2023 10:51
averyjohnston
changed the title
averyjohnston
commented
Nov 14, 2023
| * we wrap both the start and end slots in separate | ||
| * elements and apply our padding styles to that instead. | ||
| */} | ||
| <div class="start-slot-wrapper"> |
Contributor
Author
There was a problem hiding this comment.
If desired, I can hide these wrappers via CSS or avoid rendering them entirely if there isn't any slotted content provided. I figured it'd be better to keep things simple since keeping them doesn't hurt anything aside from having an extra node in the DOM, but I'm cool with making that change.
averyjohnston
commented
Nov 14, 2023
Comment on lines
-333
to
-337
| display: flex; | ||
|
|
||
| position: relative; | ||
|
|
||
| flex-grow: 1; |
Contributor
Author
There was a problem hiding this comment.
These weren't doing anything and were likely a copy-paste goof while adding the modern syntax; .native-wrapper is set to display: grid a few lines below this.
averyjohnston
requested review from
a team and
brandyscarney
and removed request for
a team
thetaPC
approved these changes
Nov 16, 2023
Contributor
thetaPC
left a comment
thetaPC
left a comment
There was a problem hiding this comment.
LGTM, with minor change request. Everything works as intended!
Co-authored-by: Maria Hutt <thetaPC@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: Part of #26297
What is the current behavior?
With the modern form control syntax, it is not possible to add icon buttons or other decorators to the sides of
ion-textarea, as you can withion-item.What is the new behavior?
startandendslots added. While making this change, I also tweaked the CSS selectors responsible for translating the label above the input with"stacked"and"floating"placements, merging this logic into a single class managed by the TSX. I needed to add a new class for whether slot content is present, so the selectors were getting unwieldy otherwise.Docs PR TBA; I plan on knocking out all three components at once when the features are all complete, to make dev builds easier to manage.
Does this introduce a breaking change?
Other information