fix(modal): remove enable scrolling delay with sheet modal#29259
Merged
liamdebeasi merged 1 commit intoFW-621from Apr 9, 2024
Merged
fix(modal): remove enable scrolling delay with sheet modal#29259liamdebeasi merged 1 commit intoFW-621from
liamdebeasi merged 1 commit intoFW-621from
Conversation
3 tasks
sean-perkins
approved these changes
Apr 3, 2024
Contributor
sean-perkins
left a comment
sean-perkins
left a comment
There was a problem hiding this comment.
Tested on a physical iPhone and on an emulated Pixel 5, behavior looks good 👍
2 tasks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 10, 2024
Issue number: resolves #24583 --------- <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> ## What is the current behavior? <!-- Please describe the current behavior that you are modifying. --> See #24583 (comment) ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> - See #29260 and #29259. This PR is a combination of previously reviewed fixes. ## Does this introduce a breaking change? - [ ] Yes - [x] No <!-- If this introduces a breaking change: 1. Describe the impact and migration path for existing applications below. 2. Update the BREAKING.md file with the breaking change. 3. Add "BREAKING CHANGE: [...]" to the commit description when merging. See https://github.com/ionic-team/ionic-framework/blob/main/docs/CONTRIBUTING.md#footer for more information. --> ## Other information <!-- Any other information that is important to this PR such as screenshots of how the component looks before and after the change. --> Dev build: `7.8.3-dev.11712695191.1d7ec370`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: Part of #24583
What is the current behavior?
There is a noticeable delay between when users finish swiping and when scrolling is re-enabled. This is because the animation takes ~500ms to complete when finishing the swipe.
This does not align with how we re-enable scrolling in the card modal. In the card modal, scrolling is re-enabled as soon as the gesture is released.
What is the new behavior?
Does this introduce a breaking change?
Other information
Dev build:
7.8.3-dev.11712114476.152fc43dReviewers:
Please test this on a physical iOS and Android devices. Ensure that swiping the modal fully open does a) re-enable scrolling and b) re-enable scrolling without a 500ms delay.
Card Behavior
card-scroll-enable.mov
Sheet Behavior
mainsheet-scroll-enable-bad.mov
sheet-scroll-enable-good.mov