refactor(react): update tab-bar requirement on tabs#29868
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
2 tasks
tanner-reits
approved these changes
Sep 12, 2024
Contributor
tanner-reits
left a comment
There was a problem hiding this comment.
Looks good! Repro steps worked
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: N/A
What is the current behavior?
As mentioned in this PR, React
IonTabsrequiresIonTabBardo be a child, else it doesn't render and throws an error.Angular, JS, and Vue doesn't have this requirement.
What is the new behavior?
I didn't see any reason why React does not mimic the other frameworks. In order to keep consistency, I've updated the React tabs. This would allow
ion-tabsandion-tab-barcan be used as standalone elements as mentioned in the docs.IonTabsdoesn't requireIonTabBarto be a child to render.Does this introduce a breaking change?
Other information
Dev build: 8.3.1-dev.11726159792.1a6f49de
How to test:
IonTabBarIonTabsdoes not rendernpm install @ionic/react@8.3.1-dev.11726159792.1a6f49deIonTabBaris still commented outIonTabsrenders