fix(angular): add missing 'compareWith' input to standalone ion-radio-group#29870
Merged
tanner-reits merged 1 commit intoionic-team:mainfrom Oct 22, 2024
ebarooni:fix-radio-group-compare-with
Merged
fix(angular): add missing 'compareWith' input to standalone ion-radio-group#29870tanner-reits merged 1 commit intoionic-team:mainfrom ebarooni:fix-radio-group-compare-with
tanner-reits merged 1 commit intoionic-team:mainfrom
ebarooni:fix-radio-group-compare-with
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
sean-perkins
requested review from
brandyscarney,
tanner-reits and
thetaPC
and removed request for
joselrio
tanner-reits
approved these changes
Oct 22, 2024
Contributor
tanner-reits
left a comment
tanner-reits
left a comment
There was a problem hiding this comment.
LGTM! Tested locally and confirmed the fix
tanner-reits
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: resolves #29826
What is the current behavior?
When using
compareWithonion-radio-groupin Ionic Angular Standalone the following error is thrown:What is the new behavior?
compareWithonion-radio-groupin Angular Standalone is availableDoes this introduce a breaking change?