feat(config): add logLevel option to suppress ionic warnings and errors#30015
Merged
brandyscarney merged 9 commits intofeature-8.5from Jan 20, 2025
Merged
feat(config): add logLevel option to suppress ionic warnings and errors#30015brandyscarney merged 9 commits intofeature-8.5from
brandyscarney merged 9 commits intofeature-8.5from
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
sean-perkins
commented
Nov 13, 2024
BenOsodrac
approved these changes
Nov 14, 2024
Member
|
Can we put this against a feature branch? |
christian-bromann
approved these changes
Jan 20, 2025
Contributor
christian-bromann
left a comment
There was a problem hiding this comment.
Overall LGTM 👍
Nit:
I would maybe create an enum for log levels, e.g.:
const enum LogLevel {
INFO = 'INFO',
ERROR = 'ERROR',
WARN = 'WARN'
}So renaming the log levels or enhancing them will be easier.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: resolves #29814
What is the current behavior?
Developers may receive Ionic warnings and errors in their console, logs and CI runs (for tests). Currently there is not a mechanism for developers to opt-out of these logs in situations where they are intentionally configuring Ionic in a way to produce a warning.
What is the new behavior?
logLevelin the Ionic config to control the log level that Ionic will produce logs for.OFFwill completely disable all warnings and errors from IonicWARNwill log warnings and errorsERRORwill log only errorsprintIonWarningandprintIonErrorDoes this introduce a breaking change?
Other information
This feature, if accepted, should be targeted to a minor release.