feat(react-router): upgrade to react router 6#30831
Open
feat(react-router): upgrade to react router 6#30831
Conversation
Co-authored-by: Sean Perkins <13732623+sean-perkins@users.noreply.github.com>
…ter 6 Co-authored-by: Sean Perkins <13732623+sean-perkins@users.noreply.github.com>
…ct router 6 Co-authored-by: Sean Perkins <13732623+sean-perkins@users.noreply.github.com>
… router 6 Co-authored-by: Sean Perkins <13732623+sean-perkins@users.noreply.github.com>
3 tasks
thetaPC
requested changes
Jan 6, 2026
packages/react-router/test/base/src/pages/nested-outlet/NestedOutlet2.tsx
Show resolved
Hide resolved
...ges/react-router/test/base/src/pages/dynamic-ionpage-classnames/DynamicIonpageClassnames.tsx
Show resolved
Hide resolved
packages/react-router/test/base/src/pages/tab-history-isolation/TabHistoryIsolation.tsx
Show resolved
Hide resolved
thetaPC
requested changes
Jan 7, 2026
packages/react-router/test/base/src/pages/nested-params/NestedParams.tsx
Show resolved
Hide resolved
packages/react-router/test/base/src/pages/relative-paths/RelativePaths.tsx
Show resolved
Hide resolved
...ages/react-router/test/base/src/pages/nested-tabs-relative-links/NestedTabsRelativeLinks.tsx
Show resolved
Hide resolved
Contributor
There was a problem hiding this comment.
Found an issue with active styles on the tab buttons when navigating from root.
Screen.Recording.2026-01-07.at.9.44.39.AM.mov
Member
Author
There was a problem hiding this comment.
I cannot reproduce this one at all at this point, but believe it's possible it was fixed in some of my navigation fixes plus the tab fix from a while back that went into main and fixed up how tabs were updating their active state in Ionic Framework Core
packages/react-router/test/base/src/pages/root-splat-tabs/RootSplatTabs.tsx
Show resolved
Hide resolved
packages/react-router/test/base/src/pages/content-change-navigation/ContentChangeNavigation.tsx
Show resolved
Hide resolved
packages/react-router/test/base/src/pages/content-change-navigation/ContentChangeNavigation.tsx
Show resolved
Hide resolved
…itions, allowing navigation to pages not properly wrapped in ion-pages
…t overlap in nested outlets
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: resolves #24177
What is the current behavior?
Currently, Ionic Framework React Router only supports React Router 5. This has many issues and unsupported/broken features.
What is the new behavior?
With this change, Ionic Framework will support React Router 6 while still supporting transitions in the same way a native app does.
Most of what caused this change to take a long time is that React Router 5 and React Router 6 have fundamental differences in how they handle components once they're no longer part of the view. In this change, we move away from relying on React Router directly so much and have our own implementation for deciding how views get dealt with during navigation and when they're cleaned up, allowing for us to still transition between them like we need to while still using React Router as much as we possibly can.
This change will also lay the foundation for the migration to React Router 7, which will ideally be easier since most of the hard work has been dealt with here.
Does this introduce a breaking change?
Other information
Current dev build (last updated 2025-12-18):