fix: camera rotate not working on safari#75
Closed
jankal13 wants to merge 1 commit intoionic-team:masterfrom
Closed
fix: camera rotate not working on safari#75jankal13 wants to merge 1 commit intoionic-team:masterfrom
jankal13 wants to merge 1 commit intoionic-team:masterfrom
Conversation
See ionic-team#74 Signed-off-by: Jan Kalbantner <Jan.Kalbantner@wechselgott.com>
|
Just browsing this due to me looking at another issue. @mrzyte While your fix resolves the error, I think it is not the right thing todo. You just disable reading the capabilities completely, when the facingMode could not be identified by the Shouldn't you better check inside of the |
Member
|
I've sent a similar PR that checks if capabilities returned facingMode. Also, looks like there is a missing closing bracket or your forgot to delete/replace the previous line |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As described in #74, there are issues rotating the camera in a Safari browser. Adding a small change to the code solves this problem.