chore(angular): standardized approach for spec tests#1785
Merged
sean-perkins merged 2 commits intomainfrom Jun 5, 2023
Merged
Conversation
sean-perkins
requested review from
a team,
kensodemann and
mapsandapps
and removed request for
a team
Contributor
Author
|
Adding Ken for an optional review. |
mapsandapps
reviewed
May 31, 2023
Comment on lines
7
to
14
| let fixture: ComponentFixture<HomePage>; | ||
|
|
||
| beforeEach(async () => { | ||
| await TestBed | ||
| .configureTestingModule() | ||
| .compileComponents(); | ||
|
|
||
| fixture = TestBed.createComponent(HomePage); |
Contributor
There was a problem hiding this comment.
FYI, this code is duplicated in the docs and will need to be updated there.
Contributor
Author
There was a problem hiding this comment.
Opened a PR to address this: ionic-team/ionic-docs#2985
mapsandapps
approved these changes
Jun 5, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #1767
asyncmodifiers