Default RoslynSourceText #1168
Merged
Default RoslynSourceText #1168
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baronfel
approved these changes
Sep 27, 2023
TheAngryByrd
force-pushed
the
default-roslynsourcetext
branch
2 times, most recently
from
dcb3e92 to
7daa11c
Compare
TheAngryByrd
force-pushed
the
default-roslynsourcetext
branch
from
7daa11c to
8005614
Compare
nojaf
pushed a commit
to nojaf/FsAutoComplete
that referenced
this pull request
Nov 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
🤖 Generated by Copilot at afea923
The pull request updates the parser to use
RoslynSourceTextfor better performance and compatibility. It also adjusts the tests to use the new source text option.🤖 Generated by Copilot at afea923
🚀🔧🧪
WHY
Just sets SourceText to default to Roslyn for now. We can discuss when to start removing the older SourceText/LSPServers later.
See this comment
HOW
🤖 Generated by Copilot at afea923
RoslynSourceTextfor better performance and memory usage (link, link)NamedTextoption from the test cases inProgram.fsto simplify the test setup and focus on the new option (link)