Skip to content

Conversation

@baronfel
Copy link
Contributor

gets proj info fixes, build script updates and a host of codefix/code updates. paves the way for merging nightly back into main.

Some false

| _ -> None)
match isLowerAstElemWithEmptyPreXmlDoc input pos with
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dawedawe can you check this merge to make sure I did it correctly?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, works as expected 👍

DeclarationListItem *
Position *
string<LocalPath> *
(Position -> option<string>) *

Check notice

Code scanning / Ionide.Analyzers.Cli

Detect if generic type should be in the postfix position.

Prefer postfix syntax for options.
@baronfel baronfel force-pushed the merge-main-to-nightly branch from a314b29 to f145633 Compare April 23, 2024 16:10
DOTNET_ROLL_FORWARD_TO_PRERELEASE: 1

# Ensure the scaffolding code can still add items to the existing code.
- name: EnsureCanScaffoldCodeFix
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dawedawe / @nojaf the codefix isn't working on this merge for some reason - can you take a look when you get a chance please?

@TheAngryByrd TheAngryByrd enabled auto-merge (squash) April 27, 2024 18:45
@TheAngryByrd TheAngryByrd merged commit 1b9343b into ionide:nightly Apr 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants