Skip to content

Conversation

@Martin521
Copy link
Contributor

In anticipation of a need for changes due to the F# "Refactor #line processing" PR, this PR just adds a test.
The test confirms that FSAC currently doesn't respect #line directives (at least not for GOTOs), so there may not even be a need for changes. But the test might be valuable anyway.

Copy link
Member

@TheAngryByrd TheAngryByrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Want me to merge or do you have anything else on this you want to do?

@Martin521
Copy link
Contributor Author

I made it because I expected that PR to require FSAC changes, but it seems there is nothing to do.
If at some point somebody wants to implement a GoTo that follows the line directives, it will be useful.
So, if you agree, please merge it as is.

@TheAngryByrd TheAngryByrd merged commit 19bc8e5 into ionide:main Sep 24, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants