Skip to content

Conversation

@Krzysztof-Cieslak
Copy link
Member

New FSharpLint version include fixes suggestion which can be used to provide some refactorings in editor

Exposing GetF1KeywordAlternate as an endpoint lets query MSDN documentation, similarly to VS' F1.

// match result with
// | None -> [Response.info serialize "File not parsed"]
// | Some res -> [ Response.errors serialize (res.GetCheckResults.Errors, file) ]
// })
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still need this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was part of push notifications system I tried to use, which was unfortunately not working in the end. I hope to get back to it in the future.

FSharpChecker.Create(
projectCacheSize = 200,
keepAllBackgroundResolutions = true,
keepAllBackgroundResolutions = false,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this have any particular performance implications?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's the setting that is used by VS2017 - @dsyme comment about it: dotnet/fsharp#2124 (comment)

I'm actually not sure about it - since VS is 32 bit it has memory limit. We don't have this problem - personally I'd be OK with bit higher memory usage if it gives general performance boost. I guess it would be good if @dsyme commented about it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK let's go with that for now.

@rneatherway rneatherway merged commit faf516e into ionide:master Jan 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants