-
Notifications
You must be signed in to change notification settings - Fork 163
Update FSharpLint version and add endpoint for F1 Help #143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
* Change background checking * Turn off notifications
| // match result with | ||
| // | None -> [Response.info serialize "File not parsed"] | ||
| // | Some res -> [ Response.errors serialize (res.GetCheckResults.Errors, file) ] | ||
| // }) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we still need this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was part of push notifications system I tried to use, which was unfortunately not working in the end. I hope to get back to it in the future.
| FSharpChecker.Create( | ||
| projectCacheSize = 200, | ||
| keepAllBackgroundResolutions = true, | ||
| keepAllBackgroundResolutions = false, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this have any particular performance implications?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's the setting that is used by VS2017 - @dsyme comment about it: dotnet/fsharp#2124 (comment)
I'm actually not sure about it - since VS is 32 bit it has memory limit. We don't have this problem - personally I'd be OK with bit higher memory usage if it gives general performance boost. I guess it would be good if @dsyme commented about it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK let's go with that for now.
Delay most expensive operations
New FSharpLint version include fixes suggestion which can be used to provide some refactorings in editor
Exposing
GetF1KeywordAlternateas an endpoint lets query MSDN documentation, similarly to VS' F1.