Skip to content

Conversation

@cartermp
Copy link
Contributor

@cartermp cartermp commented Jan 30, 2021

Dunno if this is the right way to go about doing it, but the gist of this is:

  • Walk forward until we're at the end of the LongIdent
  • Account for properties

Mirror (to the best of my limited abilities) of dotnet/fsharp#10977

Sample code is

type C () = 
    member val P = 0 with get, set

module M = 
    let mutable x = "yeet"

let f() = 
    let c = C()
    c.P <- 12

    printfn "yeet"

@cartermp
Copy link
Contributor Author

ubuntu tests: get wrekt phillip

@baronfel
Copy link
Contributor

that looks ok, I'll stand it up on my local here in a bit to verify. This is where I wish I'd merged that diagnostics-testing harness I made for Scott Hutchison :D

@cartermp
Copy link
Contributor Author

The main thing that sucks is the double call to getParseResultsForFile , is there a way to avoid that?

@baronfel
Copy link
Contributor

yeah, you really just need the line so we should add a way to get the line for a Position to help out here

@baronfel
Copy link
Contributor

regarding the ubuntu tests, let's see what they do after this commit lands. they can be a bit flaky, but we're not doing anything here that would change any of the actual tests, so if they don't flip green I'll just force-merge.

@cartermp cartermp marked this pull request as ready for review January 30, 2021 02:14
@baronfel
Copy link
Contributor

look at these error callstacks:

System.Runtime.CompilerServices.RuntimeHelpers.DispatchTailCalls(IntPtr callersRetAddrSlot, IntPtr callTarget, IntPtr retVal)

wtf

@cartermp
Copy link
Contributor Author

hmmm.jpg, no idea what that could be

@baronfel baronfel merged commit 1ae3a94 into ionide:master Jan 30, 2021
@cartermp cartermp deleted the update-use-mutable-codefix branch January 30, 2021 04:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants