Skip to content

Add zarr notebook example #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ocefpaf merged 9 commits into from
Mar 24, 2023
Merged

Add zarr notebook example #131

ocefpaf merged 9 commits into from
Mar 24, 2023

Conversation

@ocefpaf
Copy link
Member

@ocefpaf ocefpaf commented Mar 20, 2023 •
edited
Loading

Thank you for send a Pull Request to our code gallery! When adding or updating a notebook please check if:

  • The notebook has all the dependencies required to run in the IOOS env, if not please update the environment file.
  • You added a title, description, and a line with Created: YYYY-MM-DD in the first cell.
  • If you are updating a notebook add a line with Updated: YYYY-MM-DD below the created date.

Alternative to #98

@ocefpaf ocefpaf mentioned this pull request Mar 20, 2023
Closed
3 tasks
@ocefpaf
Copy link
Member Author

ocefpaf commented Mar 20, 2023

@MathewBiddle I'm looking into the failure in #130 but the text in this PR is ready for the first round of reviews.

@MathewBiddle
Copy link
Contributor

MathewBiddle commented Mar 20, 2023

Boo - we lost the NBReview option.

@ocefpaf
Copy link
Member Author

ocefpaf commented Mar 20, 2023

Boo - we lost the NBReview option.

Maybe we should enable it again until GH's notebook diff is being developed. But I would enable it just for this repo and not all of IOOS. What do you think?

@MathewBiddle
Copy link
Contributor

MathewBiddle commented Mar 23, 2023

Now that I enabled the "Feature Preview" I can review it just fine with the web interface. No need to reenable NBReview.

image

MathewBiddle
MathewBiddle requested changes Mar 23, 2023
View reviewed changes
Copy link
Contributor

@MathewBiddle MathewBiddle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some spelling fixes and maybe include more details about chunking (or a good link that describes it).

@ocefpaf ocefpaf force-pushed the add_zarr_notebook_example branch from 42e3407 to 18a15d4 Compare March 23, 2023 20:14
MathewBiddle
MathewBiddle approved these changes Mar 24, 2023
View reviewed changes
Copy link
Contributor

@MathewBiddle MathewBiddle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small spelling issue. Otherwise we're good to go with this!

@ocefpaf
Copy link
Member Author

ocefpaf commented Mar 24, 2023 •
edited
Loading

Getting a HTTPError: HTTP Error 503: Service Unavailable in coastwatch. That was probably a poor choice of server for this notebook but I don't want to re-write it now. Hopefully the server will become more stable in the near future.

@ocefpaf ocefpaf mentioned this pull request Mar 24, 2023
Merged
@ocefpaf ocefpaf force-pushed the add_zarr_notebook_example branch from 94fd782 to 7c237e6 Compare March 24, 2023 19:38
@ocefpaf ocefpaf merged commit c4b93f4 into ioos:main Mar 24, 2023
@ocefpaf ocefpaf deleted the add_zarr_notebook_example branch March 24, 2023 20:38
@ocefpaf ocefpaf mentioned this pull request Mar 31, 2023
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MathewBiddle MathewBiddle MathewBiddle approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ocefpaf @MathewBiddle