This repository was archived by the owner on Jun 7, 2023. It is now read-only.
ISSUE-229: Remove check consistency code, test and related docs#234
Merged
kwek20 merged 2 commits intoOct 11, 2020
Merged
Conversation
kwek20
suggested changes
Oct 5, 2020
Contributor
kwek20
left a comment
kwek20
left a comment
There was a problem hiding this comment.
Can you also remove CheckConsistencyResponse.java? Thanks for the fix!
| @@ -20,11 +20,6 @@ Checks if a transaction hash is promotable | |||
| |:---------------|:--------| | |||
| | [ArgumentException](https://github.com/iotaledger/iota-java/blob/master/jota/src/main/java/org/iota/jota/error/ArgumentException.java) | when we can't get the consistency of this transaction | | |||
Contributor
There was a problem hiding this comment.
Can you remove the exception here?
| * @see #checkConsistency(String...) | ||
| */ | ||
| @Document | ||
| public boolean isPromotable(Transaction tail) throws ArgumentException { |
Contributor
There was a problem hiding this comment.
and this method doesnt throw it anymore
| @@ -1628,7 +1626,6 @@ public boolean isPromotable(Transaction tail) throws ArgumentException { | |||
| * @return <tt>true</tt> if it is, otherwise <tt>false</tt> | |||
| * @throws ArgumentException when we can't get the consistency of this transaction | |||
Contributor
There was a problem hiding this comment.
This method still throws it, but replace explanation to "When we cant find the transaction"
Contributor
Author
|
@kwek20 done |
Contributor
|
Legend! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of change
Preparation for #229
Type of change
Choose a type of change, and delete any options that are not relevant.
How the change has been tested
run mvn clean install
Change checklist
Add an
xto the boxes that are relevant to your changes, and delete any items that are not.