Skip to content

Conversation

@ipa-rwu
Copy link
Member

@ipa-rwu ipa-rwu commented Nov 22, 2021

@ipa-nhg

  • Support deployment for ros2
    • generate dockerfile for rossystem or ros stacks
    • create compose file (without setting network for now. DDS still can work without docker network)
    • fix naming issue, e.g. folder name, image name, folder path, workflow name
    • examples:
      • system test case is here
      • stack test case is here

Copy link
Member

@ipa-nhg ipa-nhg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review ✔️
Local test for system composed by components ✔️
Local test for system composed by stacks ✔️
CI tests ✔️

Thanks a lot @ipa-rwu! great job!

@ipa-nhg ipa-nhg merged commit 6b5d18a into ipa320:master Nov 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants