Conversation
Codecov Report
@@ Coverage Diff @@
## main #153 +/- ##
==========================================
+ Coverage 18.66% 19.77% +1.11%
==========================================
Files 99 100 +1
Lines 10540 10968 +428
==========================================
+ Hits 1967 2169 +202
- Misses 8294 8512 +218
- Partials 279 287 +8
|
lidel
reviewed
Feb 2, 2023
85fcfb8 to
c091fd6
Compare
lidel
reviewed
Feb 3, 2023
Member
Author
|
@lidel I updated the PR and the Kubo PR: ipfs/kubo#9624. Every test is passing now. I'm not very happy how I ended up handling it: I added a new function to the interface. Read more about the issue here: ipfs/kubo#9624 (comment) - I feel like the alternative would require me to do deeper changes to the Hostname code. |
05642b0 to
13b6f58
Compare
6 tasks
lidel
requested changes
Feb 6, 2023
f96dcbb to
4cb72e4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #149.
Some things I want to improve:
/apiand/p2pfrom hostname and keep in Kubo (related to point before)I'm think it might be caused by us now callingUnlikely. ResolvePath returns the error of namesys.Resolve.ResolvePathinstead ofnamesys.Resolve. This is because the namesys.Resolve is part of ResolvePath and ResolvePath does more than just namesys.Resolve. So we catch some weird errors here.Note: sharness expected to fail as we changed the Gateway API interface.