-
Notifications
You must be signed in to change notification settings - Fork 148
feat(gateway): redirect ipns b58mh to cid #236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## main #236 +/- ##
==========================================
- Coverage 48.02% 47.82% -0.21%
==========================================
Files 279 273 -6
Lines 33439 33221 -218
==========================================
- Hits 16059 15887 -172
+ Misses 15694 15646 -48
- Partials 1686 1688 +2
|
01dcb8d to
f1ddd0a
Compare
dd34f67 to
55d1258
Compare
1d1d52d to
d8d1f54
Compare
b25da2d to
8891a97
Compare
e8b153e to
2ce2c08
Compare
e9cb71d to
0eb11f1
Compare
4db0e2c to
e776521
Compare
|
@lidel I updated to use |
a95ad5a to
b992239
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I think normalization to base36 reduces confusion (IPNS Names always looking the same).
Good for now, I think we will improve it further when we have time for productizing boxo/ipns as part of ipfs/specs#376.
(not merging yet, as I want to check other PRs and merge in least painful order)
b992239 to
de08310
Compare
4bb1a26 to
aaebd1f
Compare
210ccaa to
19eb6b2
Compare
7bcc0e6 to
603bdfe
Compare
603bdfe to
c3d3dde
Compare
Closes ipfs/kubo#9749. Redirects base58 encoded peer IDs to CID under the
/ipnsnamespace.Sharness will fail here. Kubo PR: ipfs/kubo#9785