fix(routing/http/client): avoid escaping comma query separator #688
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
@@ Coverage Diff @@
## main #688 +/- ##
==========================================
- Coverage 60.32% 60.29% -0.03%
==========================================
Files 243 243
Lines 31004 31005 +1
==========================================
- Hits 18704 18696 -8
- Misses 10635 10641 +6
- Partials 1665 1668 +3
|
The comma is in the "sub-delims" set of characters that don't need to be encoded in most parts of a URL, including query parameters. Golang standard library percent-escapes it for consistency, but we prefer human-readable /routing/v1 URLs, and real comma is restored here to ensure human and machine requests hit the same HTTP cache keys.
lidel
force-pushed
the
routing-query-fix
branch
from
003cf53 to
629baf5
Compare
lidel
changed the title
lidel
changed the title
gammazero
pushed a commit
that referenced
this pull request
Oct 22, 2024
(cherry picked from commit 30abd55)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes delegated routing client make IPIP-484 queries with
,instead of%2C.This is backward-compatible cosmetic fix: routing/http/server works with both
,and%2C, so clients that use boxo v0.24 will still work.Rationale
The comma is in the "sub-delims" set of characters that don't need to be encoded in most parts of a URL, including query parameters. Golang standard library percent-escapes it for consistency, but we prefer human-readable /routing/v1 URLs, and real comma is restored here to ensure human and machine requests hit the same HTTP cache keys.
cc @2color