-
Notifications
You must be signed in to change notification settings - Fork 149
refactor: use the new Reprovide Sweep interface #995
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
81c072d to
0505d4e
Compare
0505d4e to
7f108e8
Compare
Codecov Report❌ Patch coverage is @@ Coverage Diff @@
## main #995 +/- ##
==========================================
- Coverage 60.60% 60.55% -0.05%
==========================================
Files 268 268
Lines 33460 33446 -14
==========================================
- Hits 20277 20254 -23
- Misses 11513 11518 +5
- Partials 1670 1674 +4
... and 6 files with indirect coverage changes 🚀 New features to boost your workflow:
|
7ea011c to
8b6d074
Compare
792483b to
fbf4754
Compare
52ebc03 to
e66b18d
Compare
changed log.Errorf to log.Debugf for providing debug message
clarifies when force=true vs force=false should be used for rate limiting and caching strategies
01ed271 to
205b900
Compare
|
Colo discussion:
Discussion is how to make StartProvidingAsync():
|
b1b37ca to
f2b4e12
Compare
15993dc to
4684512
Compare
|
Reverted all deadlock related changes and applied @gammazero suggestion (#995 (comment)) in 4684512 |
gammazero
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Triage:
|
1952016 to
317bc43
Compare
Companion PR to ipfs/kubo#10834
Warning
Don't merge before ipfs/kubo#10834 is ready to be merged, otherwise kubo compatibility will be broken
This builds on top of #976 to use the latest Provide interface as defined by the Reprovide Sweep.
It is necessary since Kubo will start using the new provide interface, and won't be able to satisfy the old provide interface required by boxo. Under the hoods, it is still possible to keep the same behavior as before this PR by using a wrapper around the old provider interface.