Skip to content

Dockerize#352

Merged
aschmahmann merged 14 commits intomasterfrom
dockerize
Jun 23, 2021
Merged

Dockerize#352
aschmahmann merged 14 commits intomasterfrom
dockerize

Conversation

@thattommyhall
Copy link
Member

Should fix #351, work-around for #350 if they use Docker instead, addresses how to agree versions from #343

@welcome
Copy link

welcome bot commented Jun 2, 2021

Thank you for submitting this PR!
A maintainer will be here shortly to review it.
We are super grateful, but we are also overloaded! Help us by making sure that:

  • The context for this PR is clear, with relevant discussion, decisions
    and stakeholders linked/mentioned.

  • Your contribution itself is clear (code comments, self-review for the
    rest) and in its best form. Follow the code contribution
    guidelines

    if they apply.

Getting other community members to do a review would be great help too on complex PRs (you can ask in the chats/forums). If you are unsure about something, just leave us a comment.
Next steps:

  • A maintainer will triage and assign priority to this PR, commenting on
    any missing things and potentially assigning a reviewer for high
    priority items.

  • The PR gets reviews, discussed and approvals as needed.

  • The PR is merged by maintainers when it has been approved and comments addressed.

We currently aim to provide initial feedback/triaging within two business days. Please keep an eye on any labelling actions, as these will indicate priorities and status of your contribution.
We are very grateful for your contribution!

Copy link
Contributor

@gammazero gammazero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In order for this to run correctly on most users' systems, a few small changes are needed.

thattommyhall and others added 6 commits June 5, 2021 17:06
Co-authored-by: Andrew Gillis <gammazero@users.noreply.github.com>
Co-authored-by: Andrew Gillis <gammazero@users.noreply.github.com>
Co-authored-by: Andrew Gillis <gammazero@users.noreply.github.com>
Co-authored-by: Andrew Gillis <gammazero@users.noreply.github.com>
Co-authored-by: Andrew Gillis <gammazero@users.noreply.github.com>
Co-authored-by: Andrew Gillis <gammazero@users.noreply.github.com>
Copy link
Contributor

@gammazero gammazero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gammazero
Copy link
Contributor

@thattommyhall Added a couple of other suggestions post-review.

thattommyhall and others added 4 commits June 10, 2021 18:32
Co-authored-by: Andrew Gillis <gammazero@users.noreply.github.com>
Co-authored-by: Andrew Gillis <gammazero@users.noreply.github.com>
@aschmahmann aschmahmann merged commit 2b889ce into master Jun 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Build binaries in Docker containers

3 participants