Conversation
|
Thank you for submitting this PR!
Getting other community members to do a review would be great help too on complex PRs (you can ask in the chats/forums). If you are unsure about something, just leave us a comment.
We currently aim to provide initial feedback/triaging within two business days. Please keep an eye on any labelling actions, as these will indicate priorities and status of your contribution. |
334f08a to
2d6e3de
Compare
gammazero
left a comment
There was a problem hiding this comment.
In order for this to run correctly on most users' systems, a few small changes are needed.
Co-authored-by: Andrew Gillis <gammazero@users.noreply.github.com>
Co-authored-by: Andrew Gillis <gammazero@users.noreply.github.com>
Co-authored-by: Andrew Gillis <gammazero@users.noreply.github.com>
Co-authored-by: Andrew Gillis <gammazero@users.noreply.github.com>
Co-authored-by: Andrew Gillis <gammazero@users.noreply.github.com>
Co-authored-by: Andrew Gillis <gammazero@users.noreply.github.com>
|
@thattommyhall Added a couple of other suggestions post-review. |
Co-authored-by: Andrew Gillis <gammazero@users.noreply.github.com>
Co-authored-by: Andrew Gillis <gammazero@users.noreply.github.com>
Should fix #351, work-around for #350 if they use Docker instead, addresses how to agree versions from #343