Use go-ipfs-http-client for request handling #182
Conversation
|
cc @postables. Does this break anything? |
|
@magik6k could you test this against tools like ipget? If that still works, I'm fine going ahead with this. |
|
Finally noticed the cc and got around to testing some of the tools I have that use I don't really see this as an issue, certainly not something worth trying to prevent this PR from being merged simply because:
If desired I can follow this post up with examples of the non-standard functions I'm using. For clarification, all the errors that I'm getting are tl;drLGTM but it may effect some people using this library in ways that aren't part of |
|
@postables some examples would definitely be helpful. |
This code is pretty much the same in both places, this should make the maintenance easier.
Fixes ipfs/go-ipfs-http-client#5, Depends on ipfs/go-ipfs-http-client#18