fix: show proper error state in import notifications #2452
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix import notification showing 'Imported 0 items' when imports fail - Add new translation key for failed import messages - Update notification logic to prioritize error states over success - Add visual error styling for failed import notifications - Fix icon import file extensions from .js to .tsx Fixes ipfs#2448
Contributor
Author
|
@lidel please review this |
…on-error-handling
when importing via "Add by path" fails, display the actual error message in the bottom drawer notification instead of just "Failed to import 1 item" - pass source path as init parameter in doFilesAddPath for error display - add FailedImport component to render path and error message - separate WRITE errors from ADD_BY_PATH errors in FileImportStatus - add .catch() to prevent unhandled rejection crash - add e2e test verifying error message is shown
- support IPNS paths and protocol URLs (ipfs://, ipns://) in import - show import progress in notification for path imports - preserve import history in drawer instead of clearing on new import - notification styling reflects last operation (not cumulative errors) - show errors first in drawer when last import failed - fix icon alignment and add red tint for error items - extract shared path validation to src/lib/ipfs-path.js - increase e2e viewport to 1920x1080 for test stability - add tests for import by path, trailing slash, error history
lidel
approved these changes
Jan 26, 2026
Member
lidel
left a comment
lidel
left a comment
There was a problem hiding this comment.
Thank you. Pushed some additional changes:
- fixes for both file upload and ipfs path import (as not all error paths were handled)
- showing error from API, so user knows what exactly went wrong
- resetting error state on success
- IPNS and URI support in Import → From IPFS Path
- e2e tests for all changes
Preview
Success followed by failure:
failed import of incorrect DNSLink path:
Success resets error state, but keeps historical failure:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2448