Conversation
ci is dead. long live ci. License: MIT Signed-off-by: Oli Evans <oli@tableflip.io>
ghost
assigned
License: MIT Signed-off-by: Oli Evans <oli@tableflip.io>
License: MIT Signed-off-by: Oli Evans <oli@tableflip.io>
lidel
reviewed
Feb 21, 2019
.circleci/config.yml
Outdated
| preview_url=https://ipfs.io/ipfs/$hash | ||
|
|
||
| # Preload ipfs hash on the gateway | ||
| curl --silent --output /dev/null --show-error $preview_url |
Member
There was a problem hiding this comment.
Was the intention to preload just the HTML of main page?
If not, entire thing could be preloaded asynchronously in best-effort fashion without breaking the build:
nohup curl --max-time 900 -s "https://ipfs.io/api/v0/refs?r=true&arg=${preview_url}" >/dev/null 2>&1 &
fsdiogo
suggested changes
Feb 21, 2019
.circleci/config.yml
Outdated
| docker: | ||
| - image: olizilla/ipfs-dns-deploy | ||
| environment: | ||
| DOMAIN: explore.ipld.io |
License: MIT Signed-off-by: Oli Evans <oli@tableflip.io>
hsanjuan
reviewed
Feb 22, 2019
Contributor
hsanjuan
left a comment
hsanjuan
left a comment
There was a problem hiding this comment.
Post-merge review with a couple of improvements...
| hash=$(ipfs-cluster-ctl \ | ||
| --host /dnsaddr/cluster.ipfs.io \ | ||
| --basic-auth $CLUSTER_USER:$CLUSTER_PASSWORD \ | ||
| add --rmin 3 --rmax 3 --name "$DOMAIN" \ |
Contributor
There was a problem hiding this comment.
Do not set --rmin/--rmax, that way cluster's defaults will be used.. Also, if by chance you have the [short]-commit ID available, you could add it to the --name tag so there is more info.
| --host /dnsaddr/cluster.ipfs.io \ | ||
| --basic-auth $CLUSTER_USER:$CLUSTER_PASSWORD \ | ||
| add --rmin 3 --rmax 3 --name "$DOMAIN" \ | ||
| --recursive /tmp/workspace/$BUILD_DIR | tail -n1 | cut -d " " -f 2 ) |
Contributor
There was a problem hiding this comment.
You want to use the --quietest or --Q option which only outputs the final hash, rather than tail ...
Member
Author
|
Thanks @hsanjuan that's good to know. Will update. |
olizilla
added a commit
that referenced
this pull request
Feb 22, 2019
see: #965 (review) License: MIT Signed-off-by: Oli Evans <oli@tableflip.io>
olizilla
added a commit
that referenced
this pull request
Feb 22, 2019
- let ipfs-cluster decide replication min/max - use --quieter to get the root cid, rather than fancy tail-ing. see: #965 (review) License: MIT Signed-off-by: Oli Evans <oli@tableflip.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ci is dead. long live ci.
License: MIT
Signed-off-by: Oli Evans oli@tableflip.io