refactor(ci): automate docker releases on tag pushes #138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lidel
reviewed
May 22, 2024
Member
There was a problem hiding this comment.
@galargh I believe we want to apply this to https://github.com/ipfs/someguy/blob/main/.github/workflows/docker.yml as well 🙏
lidel
approved these changes
May 22, 2024
Member
lidel
left a comment
lidel
left a comment
There was a problem hiding this comment.
lgtm, let's land this and see if tag for next release gets docker image
lidel
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using a custom GItHub token in releaser was introduced in https://github.com/ipdxco/unified-github-workflows/releases/tag/v1.0.2
I set up a custom fine-grained PAT with contents write access only to this repository. The token is owned by web3-bot and valid for 1 year.
By using custom PAT we should be able to react to tag push events in the docker publish workflow again.
Testing -> we're going to oversee the next release to make 100% sure the automation works as expected.
❓ Are there any other repos where you'd like us to introduce a change like this one?