Skip to content

fix: filter public ips #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
2color merged 5 commits into from
Dec 20, 2024
Merged

fix: filter public ips #97

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
bb2fd4c
fix: only return public ips in fallback iter
2color Dec 19, 2024
a823143
fix: sanitize last to ensure we only return public ips
2color Dec 19, 2024
3bc3c0f
docs: add coment about cached router
2color Dec 19, 2024
2bed205
Revert "fix: only return public ips in fallback iter"
2color Dec 19, 2024
c3e1f34
docs: update changelog
2color Dec 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,13 +15,14 @@ The following emojis are used to highlight certain changes:

### Added


### Changed

### Removed

### Fixed

- Fix a bug whereby, cached peers with private multiaddrs were returned in `/routing/v1/providers` responses, as they were not passing through `sanitizeRouter`.

### Security

## [v0.7.0]
Expand Down
3 changes: 2 additions & 1 deletion server.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,7 +246,8 @@
var dhtRouter router

if cachedAddrBook != nil {
dhtRouter = NewCachedRouter(sanitizeRouter{libp2pRouter{routing: dht}}, cachedAddrBook)
cachedRouter := NewCachedRouter(libp2pRouter{routing: dht}, cachedAddrBook)
dhtRouter = sanitizeRouter{cachedRouter}

Check warning on line 250 in server.go

View check run for this annotation

Codecov / codecov/patch

server.go#L249-L250 

Added lines #L249 - L250 were not covered by tests
} else {
dhtRouter = sanitizeRouter{libp2pRouter{routing: dht}}
}
Expand Down
1 change: 1 addition & 0 deletions server_cached_router.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@ const (
)

// cachedRouter wraps a router with the cachedAddrBook to retrieve cached addresses for peers without multiaddrs in FindProviders
// it will also dispatch a FindPeer when a provider has no multiaddrs using the cacheFallbackIter
type cachedRouter struct {
router
cachedAddrBook *cachedAddrBook
Expand Down
Loading