Skip to content

/routing/v1: add missing HTTP cache headers#466

Merged
lidel merged 4 commits intomainfrom
response-headers
Mar 22, 2024
Merged

/routing/v1: add missing HTTP cache headers#466
lidel merged 4 commits intomainfrom
response-headers

Conversation

@hacdias
Copy link
Copy Markdown
Member

@hacdias hacdias commented Mar 7, 2024

Request from ipfs/boxo#584.

@hacdias hacdias requested a review from lidel March 7, 2024 11:48
@hacdias hacdias self-assigned this Mar 7, 2024
@hacdias hacdias force-pushed the response-headers branch from a6cf746 to 935cea4 Compare March 7, 2024 11:53
@hacdias hacdias changed the title routing: add missing cache headers routing: add missing repsonse headers Mar 7, 2024
@hacdias hacdias changed the title routing: add missing repsonse headers routing: add missing response headers Mar 7, 2024
@hacdias hacdias force-pushed the response-headers branch from 935cea4 to db6d950 Compare March 7, 2024 11:55
lidel and others added 2 commits March 18, 2024 23:26
Co-authored-by: Russell Dempsey <1173416+SgtPooki@users.noreply.github.com>
@lidel lidel changed the title routing: add missing response headers /routing/v1: add missing HTTP cache headers Mar 22, 2024
@lidel lidel force-pushed the response-headers branch from 318782f to 814166d Compare March 22, 2024 19:48
Copy link
Copy Markdown
Member

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Added some references to RFC and the rationale behind TTL.
Merging (we can refine later, but better to have HTTP caching headers in the spec).

@lidel lidel merged commit 6783eaa into main Mar 22, 2024
@lidel lidel deleted the response-headers branch March 22, 2024 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

No open projects
Status: 🎉 Done

Development

Successfully merging this pull request may close these issues.

3 participants