This repository was archived by the owner on Jul 4, 2023. It is now read-only.
Upgrade bitswap-tuning testcases to testground-go-sdk 0.2.3 #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nonsense
reviewed
Aug 19, 2020
| "github.com/ipfs/test-plans/bitswap-tuning/utils" | ||
| ) | ||
|
|
||
| func parseType(ctx context.Context, runenv *runtime.RunEnv, client *sync.DefaultClient, h host.Host, seq int64) (int64, utils.NodeType, int, error) { |
Member
There was a problem hiding this comment.
FYI some of this parseType function and getNodeSetSeq is most probably redundant, as with the latest SDKs we have 2 types of global sequence:
- one unique global sequence for every single test plan instance (no matter which
groupit comes from) - one unique group sequence for every instance within a group (something that this part of the code appears to be implementing, as we didn't have it before).
See https://github.com/testground/sdk-go/blob/master/run/init_context.go#L36-L37
nonsense
approved these changes
Aug 19, 2020
Member
nonsense
left a comment
nonsense
left a comment
There was a problem hiding this comment.
Overall LGTM, although I haven't run this test plan.
hacdias
approved these changes
Aug 19, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bitswap-tuning testcases were using an outdated version of the SDK so metrics weren't being successfully collected in INFLUXDB when using the latest version of testground.
I also extracted to a common.go many of the functions that may come handy for the development of additional Bitswap testcases.