InterruptReply missing status and error properties

[garlandz-db]

According to the jupyter messaging docs, we should be passing a status field in the content of the InterruptReply message. However in the implementation, we are just forwarding the request content (empty) back into the reply. As such, the reply has no information on status and the error properties in case the interrupt is not successful.

My suggestion on the fix should be a try catch around the send_interrupt_children and return a { 'status' : 'ok' } if no catch occurs and otherwise { 'status': 'error', ... }.

[blink1073]

Good catch! Would you like to submit a PR?

[jasongrout-db]

It would be good to add a check in the tests at

ipykernel/ipykernel/tests/test_kernel_direct.py

Lines 71 to 73 in ea33a31

	async def test_direct_interrupt_request(kernel):
	reply = await kernel.test_shell_message("interrupt_request", {})
	assert reply["header"]["msg_type"] == "interrupt_reply"

ipykernel/ipykernel/tests/test_ipkernel_direct.py

Lines 92 to 94 in ea33a31

	async def test_direct_interrupt_request(ipkernel):
	reply = await ipkernel.test_shell_message("interrupt_request", {})
	assert reply["header"]["msg_type"] == "interrupt_reply"

(and to change those tests to send the interrupt request on the control channel instead of the shell channel).

[garlandz-db]

i can get a PR in next week @blink1073.

[blink1073]

Great, thanks!

[garlandz-db]

any idea where i can get the traceback?

[blink1073]

I would set a debug point in the tests and inspect the reply.